Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oaf): Add support to return feature properties in a specific order and/or exclude certain properties. #239

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

rkettelerij
Copy link
Collaborator

@rkettelerij rkettelerij commented Sep 18, 2024

Description

Adds support to return feature properties in a specific order. Also adds the ability to exclude certain properties from API responses. Both features work in HTML and (Geo)JSON.

Do note that properties in GeoJSON are a JSON object which has no ordering so consuming tools may still decide to render properties out-of-order.

Also upgraded to Go 1.23 since we upgraded a lib that uses Go 1.23 features. Also added a new feature to the same library: wk8/go-ordered-map#45.

Type of change

  • New feature
  • Upgrade

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij marked this pull request as ready for review September 20, 2024 12:50
@rkettelerij rkettelerij merged commit 5ee54a9 into master Sep 20, 2024
5 checks passed
@rkettelerij rkettelerij deleted the properties-in-order branch September 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants